Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cheating strategies #1388

Merged
merged 14 commits into from
May 24, 2021
Merged

Remove cheating strategies #1388

merged 14 commits into from
May 24, 2021

Conversation

drvinceknight
Copy link
Member

This follows a bug reported here: #1386

As mentioned by @marcharper:

They are fun but cause much more trouble than they are fun.

It was decided on the issue to move these "cheating" strategies
elsewhere.

Once this PR is merged I will open an issue to capture that.

@drvinceknight
Copy link
Member Author

For clarity this ends up removing the following "cheating" files: mindreader.py, mindcontrol.py and geller.py (even though geller.py was not causing any of the problems in #1386). I also ended up removing bunch of functions from strategy_utils.py as they were only used by those strategies. Not entirely sure if I've done "too" much removing.

Once this is in I'll open an issue to make sure we keep an eye on what is gone so that we can decide where to put it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants