Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contributing guide links #1395 #1396

Merged
merged 3 commits into from
Aug 24, 2021

Conversation

RobPDev
Copy link
Member

@RobPDev RobPDev commented Aug 23, 2021

I also converted the links to HTTPS and as the .org resolved to .io I changed the README to point to .io.

@RobPDev
Copy link
Member Author

RobPDev commented Aug 23, 2021

I've tried running the failing test locally, using python 3.8 it passes if types-setuptools is installed.

@drvinceknight
Copy link
Member

Thanks for this, your fixes certainly shouldn't affect the type hints so I'm guessing this might be due to an update of mypy (?). Could you add types-setuptools to this line of the workflow config: https://github.com/Axelrod-Python/Axelrod/blob/dev/.github/workflows/config.yml#L48 to check if that fixes things?

@RobPDev
Copy link
Member Author

RobPDev commented Aug 24, 2021

I've done a bit of testing, mypy==0.812 passes, mypy==0.900 requires types-setuptools.

mypy 0.900 removed library stubs.

@drvinceknight
Copy link
Member

This looks like it's sorted the problem. Thanks @RobPDev 👍

@RobPDev
Copy link
Member Author

RobPDev commented Aug 24, 2021

Just noticed this PR hasn't linked to the issue.
Fixes #1395

@meatballs meatballs merged commit 8de17ab into Axelrod-Python:dev Aug 24, 2021
@RobPDev RobPDev deleted the fix-contributing-guide-links branch August 24, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants