Move to modern packaging setup #1439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@marcharper this is a lazy move to using pyproject.toml with [flit](https://flit.pypa.io). This is the same setup I use for Nashpy so it wasn't much work to throw the files around. This will in no way pass as is: it's a WIP (as you mentioned in our call, this needs the static files to be plugged in etc...). You mentioned that you were going to work on this so happy for what I've thrown here to be ignored (it really just took me 3 minutes) but if you/we/us wanted to continue with this it would still need: - Actually getting the build to work (I'm sure there are broken static links etc); - Documentation: - the development suite uses [`tox`](https://tox.readthedocs.io/) here so we'd need to document that. - there might be some links in the documentation that are broken as I've moved the files to `src/axelrod` and moved the `tests` to their seperate dir. Let me know what you think, I can probably keeping banging rocks together to get the above done :)
|
Happy to let you do it. If we're going to mess with a lot of links, should we consider swapping axelrod and axelrod-python as the repository names? Or is that likely to break a lot of other things? |
That's a good idea! Hadn't thought about that. I don't think that would break much stuff at all... |
|
Closing this as I realised I was just creating too big a diff this way. Have opened #1440 which keeps the structure the same and just moves to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@marcharper this is a lazy move to using pyproject.toml with flit.
This is the same setup I use for Nashpy so it wasn't much work to throw
the files around.
This will in no way pass as is: it's a WIP (as you mentioned in our
call, this needs the static files to be plugged in etc...).
You mentioned that you were going to work on this so happy for what I've
thrown here to be ignored (it really just took me 3 minutes) but if
you/we/us wanted to continue with this it would still need:
links etc);
toxhere so we'd need to document that.I've moved the files to
src/axelrodand moved theteststo theirseperate dir.
Let me know what you think, I can probably keeping banging rocks
together to get the above done :)