Add back in noise parameter to tournament #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing the fix now... |
|
That's a funny one to have missed. Could you add a copy of the integration test I tweaked in the other PR to include a noisy tournament with all strategies (to avoid this happening again) ? Out on a dog walk, if I'm not clear I can add that in a bit. |
|
I'm writing a test now. Edit: the fix and test work locally. |
|
Cool, as soon as Travis is content I'll merge as a bug fix and release 1.0.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We lost the pass through of the noise parameter when tournament was refactored.