Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: players do not know length in prob end #611

Closed
wants to merge 3 commits into from
Closed

Conversation

drvinceknight
Copy link
Member

Just to check that the expected behaviour has kicked in. A cooperation
rating of 1 implies that they never defected as expected.

Just to check that the expected behaviour has kicked in. A cooperation
rating of 1 implies that they never defected as expected.
@meatballs
Copy link
Member

Sorry, but I don't like that as a unit test as it involves too much other code from within the library.

I already included a unit test in the main PR, so I don't really see the need for this at all. If it has to be there, then it's an integration test.

@drvinceknight
Copy link
Member Author

Fair enough, I'll move it in to the integration test now.

I saw your test but that doesn't test that the tournament/players do indeed behave as expected so I'd like to see it in (it should have been in before really as we have not actually been testing one of the defining properties of the prob end tournament).

Moving it now :)

Also: setting some progress bars to False.
@drvinceknight
Copy link
Member Author

34805e5 moves it (I think you're right and this is much more an integration test) and also throws in some progress_bar=False that tidy things up a bit :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants