Adding a progress bar to reading data. #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Done by keeping track of the interactions in the tournament and passing this to the ResultSetFromFile. - If this is created by directly reading from file (so that we do not know how many rows of data there are) then a quick count of the size of the file is done (this is slightly inefficient but is worth it as it gives some user feedback).
| @@ -707,16 +707,23 @@ class ResultSetFromFile(ResultSet): | |||
| by the tournament class. | |||
| """ | |||
|
|
|||
| def __init__(self, filename, progress_bar=True): | |||
| def __init__(self, filename, progress_bar=True, | |||
| num_interactions=False): | |||
There was a problem hiding this comment.
None instead of False makes more sense?
|
Looks good, I just had a couple of minor comments. |
|
I seem to have found an error, it's not quite behaving as it's supposed to. Don't merge just yet :) |
Was counting the number of interactions twice for serial play. This fixes it.
c420b54 fixes it. This is good to go. Reapplying your 1-positive-review label @marcharper (took it off just to make sure this wouldn't be merged whilst I did the one line fix). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #617
passing this to the ResultSetFromFile.
know how many rows of data there are) then a quick count of
the size of the file is done (this is slightly inefficient but is
worth it as it gives some user feedback).
Here's a gif of it reading in the file when it's not given the size of the file (there's a small delay as it counts the size of the file):
Here's a gif of it reading it in when it's given the size of the file:
We can also call it with
progress_bar=False: