Probabilistic ending spatial tournament. #674
Conversation
| def __init__(self, players, prob_end, game, repetitions, noise, edges): | ||
|
|
||
| player_indices = list(range(len(players))) | ||
| node_indices = sorted(set([node for edge in edges for node in edge])) |
There was a problem hiding this comment.
This line might be less confusing as nested for loops.
|
Looks good overall. One general comment -- there are a lot |
|
Thanks @marcharper, will address today or tomorrow :) 👍 |
- Using sets to check that spatial player graph is connected. - Add a comment to explain test. - Fix docstrings - Modify imports in property tests.
I think these were all in Is the idea that it's better to avoid full library imports in the library itself? |
I just prefer shorter lines in a case like this. It can speed up loops to import a deeper reference but I don't think that's a concern here. |
|
Makes sense. Thanks :) |
|
defcc38 adds/improves tests for noise. |
| @@ -168,6 +168,32 @@ def estimated_size(self): | |||
| size = self.__len__() * (1. / self.prob_end) * self.repetitions | |||
| return size | |||
|
|
|||
|
|
|||
| def test_graph_is_connected(edges, players): | |||
| """ | |||
There was a problem hiding this comment.
I think this might be better as a function returning a boolean - call it graph_is_connected and return True or False. The init methods then just need a line to raise an error if False.
Not sure how I missed this one!
This also adds two hypothesis test decorators (for the two spatial tournaments).