Fix floating point error in a hyp test #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drvinceknight
force-pushed
the
fixequ
branch
4 times, most recently
from
7e3fd8a
to
fd7f8cc
Compare
In some cases floating point error will make this particular test throw a different rank for the strategies.
drvinceknight
force-pushed
the
fixequ
branch
from
fd7f8cc
to
4a0bf57
Compare
meatballs
approved these changes
Sep 26, 2016
|
@meatballs I would suggest we perhaps merge this in? It's arguably a bug, the change is very minor and @marcharper is busy at the moment (just thinking as this perhaps holds back #717...). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases floating point error will make this particular test throw
a different rank for the strategies.