Implement doubler strategy from PRISON project #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 22, 2016 14:42
Add Doubler class. Add the strategy to strategies pool.
Tweak docstrings.
drvinceknight
requested changes
Oct 22, 2016
| class Doubler(Player): | ||
| """ | ||
| Cooperates except when the opponent defected and | ||
| opponent's cooperations are less than twice as often |
There was a problem hiding this comment.
Could this be changed to:
and opponent's cooperation count is less than twice their defections.
@meatballs what do you think? Your judgement is way better than mine with these things.
There was a problem hiding this comment.
How about:
Cooperates except when the opponent has defected and
the opponent's cooperation count is less twice their defection count.
Rephrase docstrings.
drvinceknight
approved these changes
Oct 23, 2016
|
Thanks @mturzanska 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #379