Fixes the cache bug. #782
Merged
Fixes the cache bug. #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #779 This makes the underlying read/write of the cache be the string repr. The passed key is the player instances (as opposed to previously going to have to go get the class).
Merged
marcharper
requested changes
Dec 4, 2016
| key: tuple | ||
| A 3-tuple: (player instance, player instance, match length) | ||
| """ | ||
| return key[0].name, key[1].name, key[2] |
There was a problem hiding this comment.
Can we check if the player has been instantiated? This could still fail in the same way, no?
There was a problem hiding this comment.
This is assuming that key[0] and key[1] are instance of the Player class. I have modified the valid key check to check that that's indeed the case.
There was a problem hiding this comment.
def _is_valid_key(self, key):
 """Validate a proposed dictionary key
@@ -85,8 +103,8 @@ def _is_valid_key(self, key):
 # integer
 try:
 if not (
 - issubclass(key[0], Player) and
 - issubclass(key[1], Player) and
 + isinstance(key[0], Player) and
 + isinstance(key[1], Player) and
 isinstance(key[2], int)
marcharper
approved these changes
Dec 4, 2016
|
@meatballs I'm merging this under the bug fix rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #779
This makes the underlying read/write of the cache be the string repr.
The passed key is the player instances (as opposed to previously going
to have to go get the class).