Nice meta #794
Merged
Nice meta #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drvinceknight
requested changes
Dec 31, 2016
| @@ -219,6 +216,19 @@ def forgiver_wrapper(player, opponent, action, p): | |||
| forgiver_wrapper, name_prefix="Forgiving") | |||
|
|
|||
|
|
|||
| def nice_wrapper(player, opponent, action): | |||
| """If a strategy wants to defect, flip to cooperate with the given | |||
There was a problem hiding this comment.
This docstring isn't correct right? There is no probability involved.
There was a problem hiding this comment.
Yep, lazy copy paste on my part.
|
One final thing, could you add a little something about this transformer to http://axelrod.readthedocs.io/en/latest/tutorials/advanced/strategy_transformers.html? |
drvinceknight
approved these changes
Dec 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once upon a time I made all the MetaWinner strategies "nice" -- they never defect unless the opponent does first. This added a lot of nice strategies to the library. In this PR I add a transformer to make any strategy nice, and diversify the meta strategy collection a bit by making some not nice.
I recommend that we remove some of the variants from the standard collection in the near future-- there's not much difference in performance among the variants, and there are a number of better strategies incoming. But that's a conversation for another PR.