Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to eigen.py #814

Merged
merged 2 commits into from
Jan 14, 2017
Merged

Conversation

juliahou
Copy link
Contributor

Hi! I'm new to open source projects, and I thought this project would be a great place to get started. I'd love any feedback/hints/corrections/advice, especially as I'm not entirely sure I did this correctly.

@marcharper
Copy link
Member

Hi @juliahou8 ! Thanks for the contribution. I have one comment: rather than a namedtuple type I think it would be simpler to just use a tuple type (also from the typing module) instead of the Eigenvector namedtuple type:

Tuple[numpy.ndarray, float]

This is because we're not actually using a namedtuple (which comes from collections).

Otherwise it looks good to me!

@marcharper
Copy link
Member

Thanks! We have a two review policy for PRs so we'll need a 👍 from one of the other core devs. Usually this is pretty quick (but one is travelling so it may be a little longer than usual).

@meatballs meatballs merged commit f2b07f6 into Axelrod-Python:master Jan 14, 2017
@juliahou juliahou deleted the type-hints branch January 17, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants