Refactor Player.__new__ to automatically apply init_args #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you modify the contribution docs to reflect this please: http://axelrod.readthedocs.io/en/latest/tutorials/contributing/strategy/writing_the_new_strategy.html (There's a paragraph at the end about adding the |
|
I did change the docs :) I'll rebase. |
|
My mistake! I did a quick scan and thought it wasn't there. Will review
properly when I get a chance :)
…On Mon, 16 Jan 2017, 07:29 Marc Harper, ***@***.***> wrote:
I did change the docs :) I'll rebase.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#817 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACCGWlbl2IelWguFgt3sGcrvqc3LsCOiks5rSwAugaJpZM4LkC3F>
.
|
|
Nice! 👍 |
meatballs
approved these changes
Jan 16, 2017
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've eliminated the need for
@init_argsby modifyingPlayer.__new__and eliminated most usage ofinit_argsin the library.Player.__new__now caches theargsandkwargspassed to__init__. There's no need to explicitly use the decorator except for one case inLookerUpwhere the classes are created dynamically at runtime, but it may be possible to eliminate that as well.@meatballs This may solve your issue on #706, and if not, it should be easier to fix now.