Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping support for Python 2 #818

Merged
merged 19 commits into from
Jan 16, 2017
Merged

Conversation

rkty13
Copy link
Contributor

@rkty13 rkty13 commented Jan 15, 2017

This PR addresses #801. I have gone through all of the files and removed any support for Python 2 that I could find.

Overview of the changes I made:

  • Changed all floating point divisions that used a float() cast or had one of the operands as a float (e.g. 1.0/... or 1./....
  • Unicode strings are no longer prefixed as such: u''
  • Changed all references to superclasses to use the preferred zero-argument format super().
  • Removed all imports from the __future__ module.
  • Removed some import logic to check if Python's version was 2 or 3.

Some things I could not change:

Overall I think I have caught most of the differences between Python 2 and Python 3. Please let me know if I have missed anything or if I need to add anything else to this PR.

@marcharper
Copy link
Member

@rkty13 Can you also update the issue with what is left to do? Even if it's just the last few lines above.

Thanks!

@rkty13
Copy link
Contributor Author

rkty13 commented Jan 16, 2017

Done!

Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great contribution! Thanks!

@drvinceknight drvinceknight merged commit 0fa8fe3 into Axelrod-Python:master Jan 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants