Add type hints to random #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikoleta-v3
reviewed
Jan 16, 2017
| @@ -3,7 +3,7 @@ | |||
| from axelrod import Actions | |||
|
|
|||
|
|
|||
| def random_choice(p=0.5): | |||
| def random_choice(p=0.5: float): | |||
There was a problem hiding this comment.
Hello @souravsingh I am a member of the Axelrod team 😄!
I believe you should drop :float cause p is determined. That should be the syntax error
There was a problem hiding this comment.
I think the syntax parser wants something like (p: float = 0.5)
There was a problem hiding this comment.
@Nikoleta-v3 Nice to meet you!
I will look into the review.
@marcharper What should be the return type set? Should it be imported as Action.
There was a problem hiding this comment.
Yeah importing the type from actions.py is the way to go.
|
The PR needs a second review. |
drvinceknight
approved these changes
Jan 17, 2017
There was a problem hiding this comment.
Looks good, thanks for pitching in with the review @Nikoleta-v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a part of #808