Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to adaptive #835

Merged
merged 3 commits into from
Feb 1, 2017
Merged

Add type hints to adaptive #835

merged 3 commits into from
Feb 1, 2017

Conversation

janga1997
Copy link
Member

#808
Please review @drvinceknight @marcharper . I'm half certain I made a mistake.

@marcharper
Copy link
Member

Just one error: axelrod/strategies/adaptive.py:30: error: The return type of "__init__" must be None.

All you need to do is add -> None to __init__ as the return type.

@drvinceknight drvinceknight merged commit 747c0c0 into Axelrod-Python:master Feb 1, 2017
@janga1997 janga1997 deleted the typeHint-adaptive branch February 1, 2017 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcharper marcharper marcharper approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janga1997 @marcharper @drvinceknight