Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Type Annotations and add type test shell script #837

Merged
merged 3 commits into from
Jan 31, 2017
Merged

Conversation

marcharper
Copy link
Member

@marcharper marcharper commented Jan 31, 2017

Some of the type annotations already merged are not correct. Please be sure to run mypy on any new files with type annotations (see the included shell script). You will need to pip install mypy.

I was not able to get mypy -m axelrod to work -- it doesn't like our dynamically generated classes and I didn't track down a fix yet. (I've asked the mypy authors for advice in their gitter room.)

@souravsingh
Copy link
Contributor

souravsingh commented Jan 31, 2017

@marcharper Thanks for fixing the type annotations. Would it be possible to add an entry to documentation on testing the types annotations using mypy?

@meatballs meatballs merged commit e0dc2ce into master Jan 31, 2017
@meatballs meatballs deleted the typing branch January 31, 2017 11:08
@marcharper
Copy link
Member Author

@souravsingh yes we'll add it to the docs and to travis so that mypy runs automatically for all PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants