916 #917
Merged
916 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcharper
approved these changes
Mar 20, 2017
| @@ -300,7 +300,7 @@ def strategy(self, opponent: Player) -> Action: | |||
| return C | |||
| # TFT on round 2 | |||
| if len(self.history) == 1: | |||
| return D if opponent.history[-1:] == [D] else C | |||
There was a problem hiding this comment.
I think we use this because that's how TFT is actually implemented in the library, where we don't know that the history length is greater than zero. I don't have a preference here and I think your line might be more readable, but we might prefer consistency. So I'm approving and I'll let @drvinceknight and @meatballs weigh in if they have a preference.
There was a problem hiding this comment.
No I prefer this too. This is how TFT was implemented a while ago but no longer :)
drvinceknight
approved these changes
Mar 20, 2017
| @@ -300,7 +300,7 @@ def strategy(self, opponent: Player) -> Action: | |||
| return C | |||
| # TFT on round 2 | |||
| if len(self.history) == 1: | |||
| return D if opponent.history[-1:] == [D] else C | |||
There was a problem hiding this comment.
No I prefer this too. This is how TFT was implemented a while ago but no longer :)
|
Closes #917 (so that github will close the issue for us). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #916