Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884: VeryBad #928

Merged
merged 1 commit into from
Mar 25, 2017
Merged

884: VeryBad #928

merged 1 commit into from
Mar 25, 2017

Conversation

ebeweber
Copy link

Awesome project - I'm currently working my way through Coursera's Game Theory course and found this repository after listening to the recent Talk Python podcast episode.

Changes

  • refactors tests.strategies.test_verybad to my understanding of Refactor all strategy tests #884 & readthedocs
  • from my understanding of expected behavior, this fixes a miscalculation when checking if the move is one of the first three
  • a few whitespace / pep8 related changes to these two files

Looking forward to feedback and potentially diving deeper into this project.

- refactor test.strategies.test_verybad to use versus_test

- fix VeryBad computation of first three rounds
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great @ebeweber! Thanks for the contribution and welcome to the project :)

We have a two core reviewer system, so one of the other core reviewers (who you listened to on the podcast) will come along when they get a moment and either merge or potentially find something I've missed.

Looking forward to future contributions :)

@meatballs meatballs merged commit 81fc165 into Axelrod-Python:master Mar 25, 2017
@ebeweber ebeweber deleted the ebeweber-884-verybad branch March 25, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants