Update test_selfsteem.py #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drvinceknight
requested changes
Mar 26, 2017
There was a problem hiding this comment.
Thanks @alajara! This is looking good now, just the one minor PEP8 fix :)
|
|
||
| # Check for f > 0.95, defect | ||
| actions = [(C, C), (C, C), (D, C), (D, C)] | ||
| self.versus_test(axelrod.Cooperator(), expected_actions = actions) |
There was a problem hiding this comment.
Could you change expected_actions = actions to expected_actions=actions (no space either side of =).
This is a PEP8 thing.
drvinceknight
approved these changes
Mar 26, 2017
meatballs
requested changes
Mar 26, 2017
| self.responses_test([D], [C] * 16, [D] * 16) | ||
| self.responses_test([C], [D] * 9, [C] * 9) | ||
|
|
||
| # Check for f > 0.95, defect |
There was a problem hiding this comment.
Lines 24-57 are over indented - they have gained an extra 4 spaces of indentation.
Could you move them all back to 8 spaces rather than 12?
|
I'm happy if you are @meatballs. |
meatballs
approved these changes
Mar 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.