Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Type hints to hmm #949

Merged
merged 2 commits into from
Mar 31, 2017
Merged

Add Type hints to hmm #949

merged 2 commits into from
Mar 31, 2017

Conversation

MariosZoulias
Copy link
Contributor

@MariosZoulias MariosZoulias commented Mar 29, 2017 •
edited

#808
I made some changes but i think there are more .
I will delte the 9-10 lines (comments).
I will do more tommorow !!!

@MariosZoulias MariosZoulias changed the title Just a beggining of type hinting for hmm.py file Add type hints to hmm Mar 29, 2017
@MariosZoulias MariosZoulias changed the title Add type hints to hmm Add Type hints to hmm Mar 29, 2017
@MariosZoulias MariosZoulias changed the title Add Type hints to hmm Add Type hints to hmm #issue number #issue number Mar 29, 2017
@MariosZoulias MariosZoulias changed the title Add Type hints to hmm #issue number #issue number Add Type hints to hmm Mar 29, 2017
drvinceknight
drvinceknight requested changes Mar 30, 2017
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this file "axelrod/strategies/ann.py" to Axelrod/run_mypy.py? This will ensure that the automated tests check the type hints on this file :)

drvinceknight
drvinceknight approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! Thanks @MariosZoulias :) 👍

@meatballs meatballs merged commit 86c21c2 into Axelrod-Python:master Mar 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drvinceknight drvinceknight drvinceknight approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MariosZoulias @drvinceknight @meatballs