Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use kwargs for Player initialisation throughout library #952

Merged
merged 32 commits into from
Apr 1, 2017
Merged

Use kwargs for Player initialisation throughout library #952

merged 32 commits into from
Apr 1, 2017

Conversation

meatballs
Copy link
Member

Fixes #945

@meatballs
[945] Use keyword argument for Cycler in test
2d9f630
@meatballs
[945] Use keyword argument for MockPlayer
37098fc
@meatballs
[945] Use keyword argument for Random player
e612221
@meatballs
[#945] Use keyword argument for Random in test_moran
28e7589
@meatballs
[#945] Use keyword arguments in test_mock_player
806c71a
@meatballs
[#945] Replace init_args with init_kwargs in fingerprint
193882d
@meatballs
[#945] Use keyword argument for Random in test_fingerprint
c142104
@meatballs
[#945] Use keyword arguments in test_classification
c623864
@meatballs
[#945] Use keyword argument for MockPlayer in strategy tests
2ebdd60
@meatballs
[#945] Use keyword arguments in test_sequence_player
f66ae10
@meatballs
[#945] Use keyword arguments in test_rand
8299563
@meatballs
[#945] Use kwargs in test_prober
6c64a61
@meatballs
[#945] Use kwargs in test_meta
6b1d091
@meatballs
[#945] Use kwargs in tes_memoryone
ee3a263
@meatballs
[#945] Use kwargs in test_lookerup
9330350
@meatballs
[#945] Use kwargs in test_hmm
dc4efdb
@meatballs
[#945] Use kwargs in test_gambler
cb50ea1
@meatballs
[#945] Use kwargs in test_finite_machine
5df4359
@meatballs
[#945] Use kwargs in test_cycler
2532e9f
@meatballs
[#945] Use kwargs in test_cooperator
0e46174
@meatballs
[#945] Use kwargs in test_calculator
069267d
@meatballs
[#945] Use kwargs in test_backstabber
2bcbd5c
@meatballs
[#945] Use kwargs in test_matches
702147f
@meatballs
[#945] Use kwargs in docs
a929790
@meatballs
[#945] Use kwargs in writing tests doc
ee1a21f
@meatballs
[#945] Add tests for positional and keyword arguments to Player classes
7244427
@meatballs
[#945] Tidy up init_kwargs test
f3498c4
@meatballs
[#945] Add test for unknown keyword argument
191e527
@meatballs
[#945] Use proper unittest assertions
45176fa
@meatballs
[#945] Use kwargs in test_doubler
44194b0
drvinceknight
drvinceknight approved these changes Mar 31, 2017
View reviewed changes
Copy link
Member

@drvinceknight drvinceknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. 👍

@drvinceknight drvinceknight mentioned this pull request Mar 31, 2017
Merged
@marcharper
Copy link
Member

I approve -- not sure about the merge order so I'll let you all push the button since I've not been as involved in the discussions.

@drvinceknight drvinceknight merged commit 49b5f1a into master Apr 1, 2017
@marcharper marcharper deleted the issue-945 branch July 19, 2017 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drvinceknight drvinceknight drvinceknight approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@meatballs @marcharper @drvinceknight