Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

842 - Approximate Moran Process #955

Merged
merged 6 commits into from
Apr 3, 2017
Merged

842 - Approximate Moran Process #955

merged 6 commits into from
Apr 3, 2017

Conversation

drvinceknight
Copy link
Member

@drvinceknight drvinceknight commented Apr 1, 2017

Closes #842

Adds an approximate Moran process that can take a sample of match outcomes (so that these are not rerun every time).

This also makes a random_.Pdf class available, which is a generic probability distribution function with a sample method (could be useful elsewhere).

Copy link
Member

@marcharper marcharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Just the one little change please.


class TestPdf(unittest.TestCase):
"""A suite of tests for the Pdf class"""
observations = [('C', 'D')] * 4 + [('C', 'C')] * 12 + \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C and D instead of 'C' and 'D'

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Bad habits die hard. Done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants