Un-numpification and introduce payoff matrix #96
Conversation
|
This 'core dependency' of numpy, unless I've missed something along the way in the PRs, it's only needed to run results right? Would someone be able to use this library without numpy? (Not to run the tournament). Not the end of the world if I've indeed missed that. |
|
Probably worth adding a |
|
I have not read all of the PRs along the way, and I don't understand what you mean exactly, but you do now import NumPy in And since result_set is used by |
|
Sorry for not being clear. At one point I really wanted to keep this written in pure Python except for things like plotting obviously. Do you think this is something worth aiming for? The stuff we're using What do you think? Worth sticking trying to stick to pure Python or should we just embrace using appropriate libraries where they are appropriate. Hold on this isn't a conversation for here, here's an issue: #98 With regards to this actual PR: is this ready to be pulled in or is there more coming? |
|
There is some more coming, but feel free to pull at will since I cannot predict when I will have a moment to sit down and write. |
langner
changed the title
langner
changed the title
|
This looks like a big piece of work: thanks! Need a hand getting the tests right or are you ok to keep working on it? |
|
The tests now pass and I resolved merge cobflicts with master. |
|
|
||
| # Save plot with average payoff matrix with winners at top. | ||
| pmatrix_ranked = [[results.payoff_matrix[r1][r2] for r2 in results.ranking] for r1 in results.ranking] | ||
| fig, ax = plt.subplots() |
There was a problem hiding this comment.
Does this not need to be in the line if boxplot.matplotlib_installed: statement?
There was a problem hiding this comment.
No, because there is a conditional continue two lines before that for the opposite case.
|
Love the heat maps. |
|
Missed that: awesome. |
Un-numpification and introduce payoff matrix
Un-numpification and introduce payoff matrix
No description provided.