Sherlock [9]: Add tests for overflow when calling curate() #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJem
force-pushed
the
fix-review-curate-overflow
branch
from
ba88644
to
0bf8eaf
Compare
0xJem
force-pushed
the
fix-review-curate-overflow
branch
from
0bf8eaf
to
6b2426f
Compare
Oighty
changed the base branch from
fix-settle-dos
to
fix-review-delayed-private-key-2
Oighty
changed the title
Oighty
force-pushed
the
fix-review-curate-overflow
branch
from
6b2426f
to
1e8c87b
Compare
Sherlock [18]: Cap curator fee at max for type on auction creation
Sherlock [17]: Fix application of fee estimate in Catalogue
Sherlock [16]: Fixes inconsistent price math between EMPAM and queue
Sherlock [15]: Fix refundBid DoS and high gas costs
Sherlock [14]: Fix Blast address and gas claim configuration
Sherlock [13]: Add setter for minAuctionDuration
Sherlock [12]: Allow minting vesting tokens that have reached expiry
Sherlock [11]: Fix cancel auction at conclusion
Sherlock [10]: revert on zero transfers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests to confirm fix for sherlock-audit/2024-03-axis-finance-judging#88 that were not included in #130