Add video util protobuf to SDK #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 16, 2024 16:37
added 4 commits
March 16, 2024 17:18
Corallo
commented
Mar 26, 2024
| @@ -108,11 +108,11 @@ def build_signature_def(inputs=None, outputs=None, method_name=None): | |||
| types_pb2.DT_UINT64: np.uint64, | |||
| types_pb2.DT_INT16: np.int16, | |||
| types_pb2.DT_INT8: np.int8, | |||
| types_pb2.DT_STRING: np.object, | |||
| types_pb2.DT_STRING: object, | |||
There was a problem hiding this comment.
np.object and np.bool are deprecated,
this is to fix future problem with NumPy compatibility
pataxis
approved these changes
Apr 3, 2024
sdk/Dockerfile.aarch64
Outdated
| @@ -581,6 +574,7 @@ COPY --from=build-python-pytesseract $TARGET_ROOT $SDK_ROOT_DIR/python-pytessera | |||
| COPY --from=build-python-tfserving $TARGET_ROOT $SDK_ROOT_DIR/python-tfserving | |||
| COPY --from=build-python-scipy $TARGET_ROOT $SDK_ROOT_DIR/python-scipy | |||
| COPY --from=build-tesseract $TARGET_ROOT $SDK_ROOT_DIR/tesseract | |||
| COPY --from=build-python-vdoproto $TARGET_ROOT $SDK_ROOT_DIR/python-vdoproto | |||
| RUN python3 -m pip install protobuf==4.21.1 six==1.16.0 grpcio==1.46.3 | ||
| RUN python3 -m pip install --no-dependencies grpcio-tools==1.47.0 | ||
| RUN mkdir -p $TARGET_ROOT/usr/lib/$(cat /tmp/python_version)/site-packages | ||
| RUN python3 -m grpc_tools.protoc -I . --python_out=$TARGET_ROOT/usr/lib/$(cat /tmp/python_version)/site-packages --grpc_python_out=$TARGET_ROOT/usr/lib/$(cat /tmp/python_version)/site-packages videocapture.proto |
There was a problem hiding this comment.
In documentation I can only see protoc -I SRC_DIR --python_out=DST_DIR path/to/file.proto, but is this format is due to an older version of grpc_tools?
There was a problem hiding this comment.
Yes, we started to use this solution last year because of a problem with versions compatibility between python packages.
We could revisit this when we will work on simplifying the CV SDK
sdk/vdoproto/setup.py
Outdated
There was a problem hiding this comment.
It is used during the installation at line 396
Change-Id: I871ce471bcd1afb2e33aef7560fe480fae533850
…cations/acap-computer-vision-sdk into feature/vdo-protobuf * 'feature/vdo-protobuf' of https://github.com/AxisCommunications/acap-computer-vision-sdk: tf_proto_utils: add 2 min waiting time for model (#57) Change-Id: I04518ed1193937a5e163e231297d040d8a8c5423
Change-Id: Id0208d70b58fdc2e08ffdfa7954c698ff1295d26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
High Level Changes:
Details:
Checklist before requesting a review