Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RetryScheduler incorrectly retries CommandExecutionException containg an AxonNonTransientException #1199

Closed
YvonneCeelie opened this issue Aug 16, 2019 · 0 comments · Fixed by #1743
Closed

RetryScheduler incorrectly retries CommandExecutionException containg an AxonNonTransientException #1199

YvonneCeelie opened this issue Aug 16, 2019 · 0 comments · Fixed by #1743
Assignees
@sandjelkovic
Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Milestone
Release 4.5.1

Comments

@YvonneCeelie
Copy link
Contributor

YvonneCeelie commented Aug 16, 2019 •
edited by smcvb

When an org.axonframework.serialization.SerializationException is thrown upon command handling, that command is being retried if a distributed CommandBus implementation is being used.

This follows from the fact that such an exception will be wrapped in a CommandExecutionException, which will maintain the original exception as a String instead of a Throwable. Because of the current implementation of the AbstractRetryScheduler only the given exception's class hierarchy is verified to be explicitly non transient, whilst this problem requires the CommandExecutionException details to be verified.
@smcvb smcvb added Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Type: Bug Use to signal issues that describe a bug within the system. labels Aug 19, 2019
@smcvb smcvb added this to the Release 4.2.1 milestone Aug 19, 2019
@abuijze abuijze modified the milestones: Release 4.2.1, Release 4.2.2 Nov 19, 2019
@smcvb smcvb added Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. and removed Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels Jan 13, 2020
@smcvb smcvb modified the milestones: Release 4.2.2, Release 4.4 Jan 13, 2020
@smcvb smcvb changed the title When a nonTransientException is thrown on the Command handling side it is not recognized as such in the IntervalRetryScheduler RetryScheduler incorrectly retries CommandExecutionException containg an AxonNonTransientException Jan 13, 2020
@smcvb smcvb modified the milestones: Release 4.4, Release 4.5 Jul 2, 2020
@sandjelkovic sandjelkovic self-assigned this Dec 3, 2020
@smcvb smcvb added the Status: In Progress Use to signal this issue is actively worked on. label Jan 22, 2021
@smcvb smcvb modified the milestones: Release 4.5, Release 4.5.1 Mar 4, 2021
@sandjelkovic sandjelkovic mentioned this issue Mar 26, 2021
Merged
@close-label close-label bot added the Status: Resolved Use to signal that work on this issue is done. label May 12, 2021
@smcvb smcvb removed the Status: In Progress Use to signal this issue is actively worked on. label May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandjelkovic sandjelkovic

Labels
Priority 3: Could Low priority. Issues that are nice to have but have a straightforward workaround. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.5.1
Development

Successfully merging a pull request may close this issue.

[#1199] Non transient remote exceptions transport fix AxonFramework/AxonFramework
4 participants
@abuijze @smcvb @sandjelkovic @YvonneCeelie