Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Spring boot 3. #320

Merged
merged 4 commits into from Jan 30, 2023
Merged

Add support for Spring boot 3. #320

merged 4 commits into from Jan 30, 2023

Conversation

gklijs
Copy link
Contributor

@gklijs gklijs commented Jan 27, 2023

Also, add a test module, and add Java 17 job, which is also used for Sonar.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@gklijs gklijs added this to the Release 4.7.0 milestone Jan 27, 2023
@gklijs gklijs self-assigned this Jan 27, 2023
@gklijs gklijs requested a review from smcvb January 27, 2023 12:27
@gklijs gklijs marked this pull request as ready for review January 27, 2023 12:27
smcvb
smcvb approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One naming issue in the new module's pom. Other than that, this seems good to me.

amqp-spring-boot-3-integrationtests/pom.xml Outdated Show resolved Hide resolved
This was referenced Jan 30, 2023
Closed
Closed
Closed
Closed
Closed
@gklijs @smcvb
Update amqp-spring-boot-3-integrationtests/pom.xml
6dc7a25 
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@gklijs gklijs merged commit 7845342 into master Jan 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gklijs gklijs deleted the sb3 branch January 30, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

Assignees

@gklijs gklijs

Labels
Priority 1: Must Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.7.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gklijs @CLAassistant @smcvb