chore: fix the build problems #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate report, made PRs be not checked by sonar, fix AxonFramework#199
|
By the way - as usual for the PR with the build system, it might be needed some special attention for the steps used during the deployment/release procedure.... You can simulate these steps with sometimes, but in the end it might be tricky to debug and judge everything in advance. |
smcvb
reviewed
Nov 8, 2021
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
|
Is there anything I can do here to progress further here? |
lfgcampos
approved these changes
Nov 22, 2021
smcvb
approved these changes
Nov 25, 2021
|
Thanks for the effort and patience here @zambrovski! Just went ahead and merged the changes after approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Folks,
as promised, my first attempt. I believe this is a good step towards a more stable and comfortable build. I added a new issue #200 to clean-up pom (especially duplicate declarations and places of version declarations) and focus in this PR on the build process only.
Things changed:
itest)-Pcoverage-aggregate)I believe if you like this structure, it might be worth to create a Axon-Community Extension Parent POM project - to simplify the setup of the extension and containing explanations of usage and setup. This would ease your handling of extensions, if they are at least having the same parent and you could move some of the POM magic up to it...