Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the pom's, move version numbers to the properties section #253

Merged
merged 1 commit into from Mar 8, 2022

Conversation

gklijs
Copy link
Collaborator

@gklijs gklijs commented Mar 8, 2022

Clean up the pom's, move version numbers to the properties section, also move to 'kafka-clients' as we don't need the Scala code. It's also the dependency Spring Kafka uses.
Completes #200

@gklijs gklijs added this to the Release 4.6.0 milestone Mar 8, 2022
@gklijs gklijs requested review from smcvb and lfgcampos March 8, 2022 08:48
@gklijs gklijs self-assigned this Mar 8, 2022
@gklijs gklijs marked this pull request as draft March 8, 2022 08:57
@gklijs gklijs marked this pull request as ready for review March 8, 2022 10:42
…lso move to 'kafka-clients' as we don't need the scala code.
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gklijs gklijs merged commit 0b5002a into master Mar 8, 2022
@gklijs gklijs deleted the clean_up_poms branch March 8, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants