Updated serializer configuration and made them lazy #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is expected to be a whole or part of the fix for AxonFramework/AxonFramework#2184 |
gklijs
requested changes
Apr 22, 2022
...amework/extensions/kafka/eventhandling/consumer/streamable/StreamableKafkaMessageSource.java
Show resolved
Hide resolved
...ava/org/axonframework/extensions/kafka/autoconfig/KafkaAutoConfigurationIntegrationTest.java
Show resolved
Hide resolved
gklijs
requested changes
Apr 25, 2022
There was a problem hiding this comment.
There still some complains from sonar, looks like adding @SuppressWarnings("squid:S1874") is the only valid fix for the parametrized types. Not sure there is a good fix for the duplicated code. Guess we could have some helper function, for example to get a default supplier? https://sonarcloud.io/project/issues?resolved=false&types=CODE_SMELL&sinceLeakPeriod=true&pullRequest=280&id=AxonFramework_extension-kafka
gklijs
approved these changes
Apr 25, 2022
smcvb
approved these changes
Apr 26, 2022
...amework/extensions/kafka/eventhandling/consumer/streamable/StreamableKafkaMessageSource.java
Outdated
Show resolved
Hide resolved
...ork/extensions/kafka/eventhandling/consumer/subscribable/SubscribableKafkaMessageSource.java
Outdated
Show resolved
Hide resolved
.../src/main/java/org/axonframework/extensions/kafka/eventhandling/producer/KafkaPublisher.java
Outdated
Show resolved
Hide resolved
Keeps it consistent with the framework and gives us a chance to notify the user they are using a default serializer and they shouldn't
sandjelkovic
approved these changes
Apr 26, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal for this PR is to do the same we did on Framework, making Serializers lazy and only initializing them if the user doesn't provide one.
It has an added benefit of not always initializing XStream.
For making it work, the initialization of the
messageConverterwas also pushed to the end of the builder call.I am not sure we have meaningful tests to be added in this case.