Remove the use of a consumer group for StreamableKafkaMessageSource. #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcvb
approved these changes
May 9, 2022
...rc/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/ConsumerSeekUtil.java
Show resolved
Hide resolved
...rc/main/java/org/axonframework/extensions/kafka/eventhandling/consumer/ConsumerSeekUtil.java
Outdated
Show resolved
Hide resolved
...amework/extensions/kafka/eventhandling/consumer/streamable/StreamableKafkaMessageSource.java
Outdated
Show resolved
Hide resolved
...amework/extensions/kafka/eventhandling/consumer/streamable/StreamableKafkaMessageSource.java
Outdated
Show resolved
Hide resolved
...tensions/kafka/eventhandling/consumer/streamable/TrackingTokenConsumerRebalanceListener.java
Show resolved
Hide resolved
...g/axonframework/extensions/kafka/eventhandling/consumer/ConsumerSeekUtilIntegrationTest.java
Show resolved
Hide resolved
smcvb
approved these changes
May 9, 2022
Mainly because it's kind of a bug fix and we might want to release it earlier. But if you think it's fine/better to add to master I'll happily rebase. |
Cool, just wanted to check, as the original issue still points to 4.6.0. |
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273 by instead of relying on a different consumer id each time, to ensure all the partitions are consumed, setting the partitions manually.