Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KafkaPublisher as conditional, such that it's easier to use the autoconfig. #307

Merged
merged 1 commit into from Jul 7, 2022

Conversation

gklijs
Copy link
Collaborator

@gklijs gklijs commented Jul 7, 2022

Fixes #306
seems like a legacy requirement that is no longer needed, and actually makes it harder to use the autoconfig in some cases.

@gklijs gklijs added this to the Release 4.5.5 milestone Jul 7, 2022
@gklijs gklijs requested a review from smcvb July 7, 2022 11:57
@gklijs gklijs self-assigned this Jul 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 62 Code Smells

87.4% 87.4% Coverage
2.0% 2.0% Duplication

Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@gklijs gklijs merged commit 55061ce into axon-kafka-4.5.x Jul 7, 2022
@smcvb smcvb deleted the bug/306 branch July 8, 2022 08:40
@smcvb smcvb modified the milestones: Release 4.5.5, Release 4.6.0 Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants