Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pom improvements #37

Merged
merged 8 commits into from
Sep 24, 2020
Merged

pom improvements #37

merged 8 commits into from
Sep 24, 2020

Conversation

zambrovski
Copy link
Collaborator

@zambrovski zambrovski commented Sep 21, 2020 •
edited

Following improvements:

  • mvn Wrapper provides an easy way to be independent from installed maven version
  • in parent pom, the "plugin management" defines all required plugins (including versions and configurations)
  • the behavior of the "build" should not be inherited from the parent. The "pom" module doesn't need compiler plugin runs (this produces errors and warnings during build) - these are defined in "jar" modules only
  • creation of Javadoc and Sources is moved to a profile inside the Kotlin module. It is automatically triggered during release but can be invoked as described in the readme too.
  • switched to latest version of dokka (1.4.0) which generates javadoc in JDK versions [8,11,...]
  • added .editorconfig file, to ease the formatting of the code
  • this will fix Fix problems building on JDK 11 #32

@zambrovski zambrovski changed the title Feature/pom improvements pom improvements Sep 21, 2020
sandjelkovic
sandjelkovic reviewed Sep 22, 2020
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
@smcvb smcvb added this to the Release 0.2.0 milestone Sep 22, 2020
@smcvb smcvb self-requested a review September 22, 2020 11:13
@zambrovski
Copy link
Collaborator Author

zambrovski commented Sep 22, 2020 •
edited

I believe we don't need Kotlin 1.4 yet, but just require Dokka 1.4.10 since it solves the JDK 11 problem.

Independent of the compilation status - please let merge this PR and then fix the code if required, since this one is pure infrastructure and not related to programming. To get the build green we need correct infrastructure first and then fix all errors.

This was referenced Sep 22, 2020
Merged
Merged
sandjelkovic
sandjelkovic approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@sandjelkovic sandjelkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

lfgcampos
lfgcampos approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pom.xml Outdated
</plugin>
<plugin>
<artifactId>maven-jar-plugin</artifactId>
<version>3.0.2</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A downgrade here but seems like a merge mistake.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dependabot will report all mistakes in downgrades, if any :-)

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit bbf07e5 into AxonFramework:master Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@sandjelkovic sandjelkovic sandjelkovic approved these changes

@lfgcampos lfgcampos lfgcampos approved these changes

Assignees

@zambrovski zambrovski

Labels
Priority 1: Must Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.

Fix problems building on JDK 11
4 participants
@zambrovski @smcvb @sandjelkovic @lfgcampos