Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation issues in tests after Kotlin 1.4 upgrade #63

Merged
merged 1 commit into from
Sep 24, 2020

Conversation

sandjelkovic
Copy link
Member

This PR will fix compilation problems in QueryGatewayExtensions tests. In one of the versions after Kotlin 1.61 type inference engine changed and couldn't handle how Mockk's match was used.

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zambrovski zambrovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit b450d41 into master Sep 24, 2020
@smcvb smcvb added this to the Release 0.2.0 milestone Sep 24, 2020
@smcvb smcvb deleted the failingTestBuildFix branch September 24, 2020 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants