Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#270] Implement SequencedDeadLetterQueue for Mongo #277

Merged
merged 1 commit into from Oct 21, 2022
Merged

[#270] Implement SequencedDeadLetterQueue for Mongo #277

merged 1 commit into from Oct 21, 2022

Conversation

gklijs
Copy link
Collaborator

@gklijs gklijs commented Oct 6, 2022 •
edited

Resolves #270

A lot was copied from the JPA implementation, with the entries and query code changed to fit Mongo.
This does include transactions with the NoTransactionManager as default.

@gklijs gklijs added this to the Release 4.7.0 milestone Oct 6, 2022
@gklijs gklijs self-assigned this Oct 6, 2022
@gklijs gklijs force-pushed the issues/270 branch 3 times, most recently from 1d2f006 to 61d9272 Compare October 7, 2022 13:55
@smcvb smcvb changed the title Implement SequencedDeadLetterQueue for Mongo [#270] Implement SequencedDeadLetterQueue for Mongo Oct 18, 2022
smcvb
smcvb requested changes Oct 18, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition so far, @gklijs! Very confident a lot of users will be extremely happy with this. However, I have (as expected) quite some pointers to cover. Not that many conceptual pointers, though.

.github/workflows/main.yml Show resolved Hide resolved
mongo/src/main/java/org/axonframework/extensions/mongo/DefaultMongoTemplate.java Show resolved Hide resolved
mongo/src/main/java/org/axonframework/extensions/mongo/DefaultMongoTemplate.java Show resolved Hide resolved
mongo/src/main/java/org/axonframework/extensions/mongo/DefaultMongoTemplate.java Show resolved Hide resolved
mongo/src/main/java/org/axonframework/extensions/mongo/DefaultMongoTemplate.java Show resolved Hide resolved
...g/axonframework/extensions/mongo/eventhandling/deadletter/MongoSequencedDeadLetterQueue.java Show resolved Hide resolved
...g/axonframework/extensions/mongo/eventhandling/deadletter/MongoSequencedDeadLetterQueue.java Outdated Show resolved Hide resolved
...g/axonframework/extensions/mongo/eventhandling/deadletter/MongoSequencedDeadLetterQueue.java Outdated Show resolved Hide resolved
...g/axonframework/extensions/mongo/eventhandling/deadletter/MongoSequencedDeadLetterQueue.java Outdated Show resolved Hide resolved
...g/axonframework/extensions/mongo/eventhandling/deadletter/MongoSequencedDeadLetterQueue.java Outdated Show resolved Hide resolved
CodeDrivenMitch
CodeDrivenMitch requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@CodeDrivenMitch CodeDrivenMitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one small issue and have some suggestions regarding the naming of queries. Other than that, great work!

@gklijs gklijs force-pushed the issues/270 branch 4 times, most recently from 0df7d06 to 7f79c6c Compare October 20, 2022 07:49
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

82.1% 82.1% Coverage
0.0% 0.0% Duplication

@gklijs gklijs merged commit 2662a73 into master Oct 21, 2022
@smcvb smcvb deleted the issues/270 branch October 26, 2022 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb requested changes

@CodeDrivenMitch CodeDrivenMitch CodeDrivenMitch requested changes

@abuijze abuijze abuijze approved these changes

Assignees

@gklijs gklijs

Labels
Priority 1: Must Status: Resolved Type: Feature
Projects
None yet
Milestone
Release 4.7.0
Development

Successfully merging this pull request may close these issues.

Implement Deadletter for Mongo
4 participants
@gklijs @abuijze @CodeDrivenMitch @smcvb