[#122] Enable load balancing strategy property configuration #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever somebody provides load balancing settings, these should be taken into account through the AdminChannel. This requires a little effort to map the strategies to the processor-to-context naming scheme, requiring a slight duplication compared to the approach taken in the EventProcessorControlService #112
smcvb
requested review from
gklijs and
CodeDrivenMitch
and removed request for
a team
|
|
gklijs
approved these changes
Oct 27, 2023
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces logic to the
MultiTenantEventProcessorsControlServicethat checks whether the user has set load-balancing strategy properties in their properties file.This logic, although present in the
EventProcessorsControlServiceit inherits from, needs a rewrite because the multi-tenant variety needs to deal with the fact the processor name and context are concatenated.Thus, a part of the changes is the mapping from processor name to strategy.
The other, larger part, is the actual invocation of the
AdminChannelto set the load balancing strategy and to enable automatic load balancing (if enabled).This latter part closely resembles the implementation of the
EventProcessorsControlServiceon this subject, by the way.In doing the above, this pull request resolves #122.