Drop properties validation in TenantDescriptor#equals
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop validation on the properties in equals. This was accidentally reintroduced during a boy scouting task throughout the project, but this was incorrect. The functionality of the multi-tenancy extension expects to match on the tenantId ONLY, as properties may differ wildly during the flow of the extension as they can be created by the extensions and/or users themselves. In those cases, a automated creation and user creation of the TenantDescriptor should simply match on the tenantId to provide the desired functionality. #bug/tenant-descriptor-equals-without-properties
schananas
requested changes
Nov 8, 2023
Drop properties from hashCode too #bug/tenant-descriptor-equals-without-properties
Sharp, and adjusted! |
|
Kudos, SonarCloud Quality Gate passed! |
schananas
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a clean-up of this repository I (yes, me) accidentally introduces the
propetiesto theTenantDescriptor#equalsmethod.This was, as it turns out, wrong.
The
TenantDescriptoris both constructed by the extension it self and by users, both not necessarily knowledgable about the properties, but definitely knowledgable about the righttenantId.To have the multi-tenancy extension behave as intended, validating the
TenantDescriptorbased on just it'stenantIdis paramount.As such, this pull request removes
propertiesfrom theTenantDescriptor#equalsmethod again.Furthermore, I have added a test case to validate the
propertiesfield does not have any influence on the behavior ofequals.