New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multitenant support #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smcvb
requested review from
a team,
gklijs and
YvonneCeelie
and removed request for
a team
September 12, 2022 15:18
…-support # Conflicts: # multitenancy-spring-boot-autoconfigure/pom.xml # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/AxonServerTenantProvider.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/ContextObject.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/MultiTenancyAutoConfiguration.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/MultiTenancyAxonServerAutoConfiguration.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/MultiTenantDataSourceManager.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/MultiTenantEventProcessorControlService.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/TenantConfiguration.java # multitenancy-spring-boot-autoconfigure/src/main/java/org/axonframework/extensions/multitenancy/autoconfig/TenantCorrelationProvider.java # multitenancy-spring-boot-starter/pom.xml # multitenancy/pom.xml # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/TenantWrappedTransactionManager.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/MultiTenantAwareComponent.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/NoSuchTenantException.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/TargetTenantResolver.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/TenantConnectPredicate.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/TenantDescriptor.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/TenantProvider.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/commandhandeling/MultiTenantCommandBus.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/commandhandeling/TenantCommandSegmentFactory.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/eventhandeling/MultiTenantEventProcessor.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/eventhandeling/TenantEventProcessorSegmentFactory.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/eventstore/MultiTenantEventStore.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/eventstore/TenantEventSegmentFactory.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/queryhandeling/MultiTenantQueryBus.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/queryhandeling/MultiTenantQueryUpdateEmitter.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/queryhandeling/TenantQuerySegmentFactory.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/components/queryhandeling/TenantQueryUpdateEmitterSegmentFactory.java # multitenancy/src/main/java/org/axonframework/extensions/multitenancy/configuration/MultiTenantEventProcessingModule.java
- Change inception year to current year - Move tests from starter module to the intended module - Make MultiTenantEventStore#storeSnapshot public - Move mockito dependency to right pom file
- Update junit jupiter to 5.9.0 - Use https for license file reference - Update jacoco maven plugin to 0.8.8 - Update assertj to 3.23.1
Ensure the Spring Boot starter POM works as intended, following the Axon Framework starter pom, by: - Setting the parent to spring-boot-starters - Setting groupId, artifactId and version number in the main file - Adding a name, for clarity - Adding organization information - Adding license information - Adding issue management information - Adding the release-sign-artifacts profile - Adding build information - Adding distribution management information - Adding scm information
The auto-config test did not include the new AxonTracingAutoConfiguration class. Due to this, the Axon Framework components failed to retrieve a SpanFactory, as none was created.
Switch dependency to spring-boot-autoconfigure, as that's what a starter pom should do.
smcvb
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through this pull request myself to make some needed fixes. In all, everything seems fine and is tested within sample applications sufficiently. As such, I approve of this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Multi-tenant support for this extension