Automatically expire ignored ServiceInstances
#168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The IgnoreListingDiscoveryMode should let ignored ServiceInstances expire after some time. This expiry time should be configurable to allow users to choose when to evict entries. #6
Adjust coverage run approach #6
|
SonarCloud Quality Gate failed. |
Adjust coverage run approach for the pull request task #6
Vermorkentech
approved these changes
Jan 27, 2022
sandjelkovic
approved these changes
Jan 27, 2022
...rg/axonframework/extensions/springcloud/commandhandling/mode/IgnoreListingDiscoveryMode.java
Outdated
Show resolved
Hide resolved
...rg/axonframework/extensions/springcloud/commandhandling/mode/IgnoreListingDiscoveryMode.java
Show resolved
Hide resolved
Adjust the threshold from long to Duration #6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the
IgnoreListingDiscoveryModeto evict ignoredServiceInstancesafter a configurable threshold.To that end, whenever a
ServiceInstanceis ignored the time of ignoring plus theexpireThresholdis stored with it.To set the time of ignoring an instance, a
public static Clockis added to theIgnoreListingDiscoveryMode.Opening up the
Clockprovides users the freedom to change it, but also enables easier testing.The
IgnoreListingDiscoveryModevalidates ignoredServiceInstancefor eviction on anycapabilities(ServiceInstance)invocation.Doing so ensure the
IgnoreListingDiscoveryModemoves in line with the heartbeats of the chosen Spring Cloud Discovery implementation.This pull request resolves #6.