[#13 & #1382] Allow Serializer Configuration & Support Spring Boot DevTools #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After local testing it showed that any axon-jar which might be active requires to be included for devtools to work without exception, including the extensions. The poms should be adjusted to allowing property filtering on this resource path, to allow usage of the exact axon version to be inserted in the properties file #1382
The Serializer should be configurable for two reasons: 1. To ensure the security warning thrown by XStream can be mitigated by users. 2. To allow setting of the ClassLoader, which is required for Spring Devtools to work correctly. #1382 & #13
lfgcampos
approved these changes
May 15, 2020
m1l4n54v1c
approved these changes
May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a
spring-devtools.propertiesfile, including the modules required for restart. After local testing (at this stage uncertain how to provide test cases for this) it showed that Spring Boot Devtools threw exceptions if any of the added jars was not included for restart.With the adjustments in place, all worked as desired. An additional adjustment was made to the
pom.xmlto allow filtering of the project version into thespring-devtools.propertiesfile.Alongside this, this PR also introduces the possibility to configure the
Serializerused by theSpringCloudCommandRouter. This was a request in issue #13 to mitigate the security concerns logged byXStream. This is however also a necessity for Spring Boot Devtools to work, as it contains a known limitation on the matter.This pull request is part of issue #1382 and resolves #13