Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JUnit4 #69

Merged
merged 2 commits into from
Jan 15, 2021
Merged

Remove JUnit4 #69

merged 2 commits into from
Jan 15, 2021

Conversation

smcvb
Copy link
Member

@smcvb smcvb commented Dec 23, 2020

This pull request removes the dependency on JUnit4. In doing so it also adjusts the last remaining test, the SpringHttpCommandBusConnectorTest, to use JUnit5 instead.

Remove the dependency on JUnit 4 and adjust all remaining tests to use
JUnit5

#remove-junit4
Copy link
Member

@sandjelkovic sandjelkovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Simply use artifact "junit-jupiter instead of separate arfects for
JUnit5

#69
Base automatically changed from feature/23 to master January 15, 2021 09:37
@smcvb smcvb merged commit 1e6a398 into master Jan 15, 2021
@smcvb smcvb deleted the feature/remove-junit4 branch January 15, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants