This repository has been archived by the owner on Oct 8, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/17 tracking processor rebalancing #14
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGathier
reviewed
Aug 27, 2018
bool running = 4; | ||
bool error = 5; | ||
repeated EventTrackerInfo event_trackers_info = 6; | ||
int32 active_threads = 3; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backwards compatibility issue. When running this client version against previous server version, the server will not be able to parse the messages (as GRPC uses the sequence numbers).
Better to change the sequence nr for available threads to 7.
MGathier
approved these changes
Aug 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved if you change the sequence of the fields in the proto definition.
…le_threads for backwards compatibility.
… status - bug fix in algorithm
…balancing' into feature/17_tracking_processor_rebalancing
This feature will not be added to AxonClient. It is already implemented in axon-server-connector. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.