Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix permit leak on cancelled query #167

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Fix permit leak on cancelled query #167

merged 1 commit into from
Mar 30, 2022

Conversation

MGathier
Copy link
Contributor

complete the response channel when a query is cancelled by the requester

@MGathier MGathier added this to the Release 4.6.0 milestone Mar 30, 2022
@MGathier MGathier self-assigned this Mar 30, 2022
m1l4n54v1c
m1l4n54v1c approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@m1l4n54v1c m1l4n54v1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch Marc!

@MGathier MGathier merged commit 812f5e4 into master Mar 30, 2022
@MGathier MGathier deleted the fix/permit-leak-on-cancel branch March 30, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1l4n54v1c m1l4n54v1c m1l4n54v1c approved these changes

Assignees

@MGathier MGathier

Labels
Priority 1: Must Status: Resolved Type: Bug
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MGathier @m1l4n54v1c @smcvb