Fix the subscriptionsCompleted boolean in query and command channels #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeDrivenMitch
requested review from
smcvb and
abuijze
and removed request for
smcvb
abuijze
requested changes
Aug 2, 2022
src/main/java/io/axoniq/axonserver/connector/command/impl/CommandChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/axoniq/axonserver/connector/command/impl/CommandChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/axoniq/axonserver/connector/command/impl/CommandChannelImpl.java
Outdated
Show resolved
Hide resolved
src/main/java/io/axoniq/axonserver/connector/query/impl/QueryChannelImpl.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
abuijze
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the
4.5.x.counterpart of #219.In normal situations, the current implementation of
QueryChannelImpl.isReady()is sufficient. However, in some very rare cases the channel stays connected, while being unable to register query handlers. Despite the failing registering of the handlers theisReady()check wrongfully believes it's health, since thesubscriptionsCompletedis never set to false in case of errors.This PR fixes this problem by setting it to false in the case of errors during registering, and setting it to false during disconnection. The boolean is then determined again when connecting and succeeding.
Note: During a normal disconnect, the outbound stream would be set to null, so it normally works in the way it should. This is for the abnormal situation where the stream is not null, but it's not connected as well.