Fix Download Message Suppression Logic #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Check whether a customized ServerAddress is provided. If yes, toggle suppressDownloadMessage - Also check whether axon.axonserver.suppressDownloadMessage is set. If yes, toggle suppressDownloadMessage - Check to set the suppressDownloadMessage at build of the AxonServerConnectionFactory - Add ServerAddress#DEFAULT for ease in validation for download message - Add tests validating the message is printed yes/no - Remove setting suppressDownloadMessage on routingServers invocation - Update copyright notices #bug/download-message-suppression
|
Kudos, SonarCloud Quality Gate passed!
|
MGathier
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves the logic around the
suppressDownloadMessagetoggle.This toggle is set to
trueon any invocation orAxonServerConnectionFactory.Builder#routingServers.However, this invocation is always invoked, hence the download message never shows.
To resolve this, this pull request checks whether:
ServerAddressis provided, andServerAddressof hostlocalhostand port8124.Next to the default address validation, reintroduce the
axon.axonserver.suppressDownloadMessageproperty check.When set, retrieve the value set under this system property.
Lastly, a test is introduced to validate that the existing
axonserver_download.txtis shared, yes/no.