Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Splitted builds into pr and not pr, added ghactions to dependabot and other minors #77

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Splitted builds into pr and not pr, added ghactions to dependabot and other minors #77

merged 2 commits into from
Jun 10, 2021

Conversation

lfgcampos
Copy link
Contributor

This PR splits our current approach for building into 2.

  • master
    • build on master/main/tags
    • will deploy to sonatype
  • pullrequest
    • build on PRs only
    • won't deploy to sonatype

Also added a small improvement to dependabot to also check for new versions of our GHActions.
Also updated some outdated action versions.

@lfgcampos lfgcampos requested review from corradom and smcvb June 9, 2021 12:41
@lfgcampos lfgcampos self-assigned this Jun 9, 2021
@CLAassistant
Copy link

CLAassistant commented Jun 9, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@smcvb smcvb added this to the Release 4.6.0 milestone Jun 9, 2021
smcvb
smcvb requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the organization parameters for the Sonar invocation should point to axoniq i.o. axonframework, since this repo belongs to AxonIQ directly.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/pullrequest.yml Outdated Show resolved Hide resolved
smcvb
smcvb requested changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the organization parameters for the Sonar invocation should point to axoniq i.o. axonframework, since this repo belongs to AxonIQ directly.

@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

67.4% 67.4% Coverage
0.0% 0.0% Duplication

@lfgcampos lfgcampos requested a review from smcvb June 9, 2021 13:44
smcvb
smcvb approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit dbe9fb5 into master Jun 10, 2021
@smcvb smcvb deleted the process-improvement branch June 10, 2021 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@corradom corradom Awaiting requested review from corradom

Assignees

@lfgcampos lfgcampos

Labels
Priority 3: Could Status: Resolved Type: Enhancement
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lfgcampos @CLAassistant @smcvb