Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: described the upcaster support in extension-kafka #227

Merged
merged 3 commits into from Dec 14, 2021

Conversation

zambrovski
Copy link
Contributor

Additional docs for AxonFramework/extension-kafka#195

Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two change requests from my end.
Other than that, all this looks good.

And, thanks for adjusting the RefGuide too @zambrovski! :-)

extensions/kafka.md Outdated Show resolved Hide resolved
extensions/kafka.md Outdated Show resolved Hide resolved
@smcvb smcvb removed the request for review from abuijze October 28, 2021 12:31
Copy link
Contributor

@lfgcampos lfgcampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming Steven's remarks will be taken into consideration, LGTM

zambrovski and others added 2 commits December 13, 2021 17:42
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
Copy link
Collaborator

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns have been addressed, hence approving.

@smcvb smcvb merged commit 472f04e into AxonIQ:master Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants