New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on every electron shutdown #157

Closed

gdavidkov opened this issue Feb 10, 2022 · 4 comments · Fixed by #168

gdavidkov commented Feb 10, 2022 •

edited

Hi,
When our Electron app shutdowns, we stop all watchers (using await watcher.stop()) and we encounter the following crash.

We are using nsfw@2.1.2 version.

7

Contributor

ianhattendorf commented Feb 16, 2022

@gdavidkov I just pushed 2.2.0, give that a shot. This might have been fixed with #151. Let me know if that fixes it.

Author

gdavidkov commented Feb 23, 2022 •

edited

@ianhattendorf Unfortunately, it is the same - crashpad generates a dump on every shutdown. I have 4 watchers and I call the stop function on each of them before calling application.exit().

Author

gdavidkov commented Mar 11, 2022

@ianhattendorf I found the problem. I have multiple watchers but I forgot to stop one of them.

Contributor

ianhattendorf commented Mar 11, 2022

Hmm, ideally we would just stop the watchers automatically on shutdown instead of crash. I'll leave this open to track that issue. Glad you were able to get it working.

julianmesa-gitkraken mentioned this issue

Fix crash on exit. #168

Merged

ianhattendorf closed this as completed in #168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment