Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix segfault on exit from an electron app #151

Merged

Conversation

julianmesa-gitkraken
Copy link
Contributor

@julianmesa-gitkraken julianmesa-gitkraken commented Nov 17, 2021

Now the code close the pollForEvents thread on destroy the NSFW object.
Also added a commit to be able to break (notify) the sleep in the pollForEvents thread, so we will not have to wait the debounceMs time on stopping the watcher or when we are destroying the NSFW object.

src/NSFW.cpp Outdated Show resolved Hide resolved
src/NSFW.cpp Show resolved Hide resolved
@julianmesa-gitkraken julianmesa-gitkraken force-pushed the fix-segfault-on-exit branch 7 times, most recently from d021183 to 2175cd4 Compare December 14, 2021 14:42
Now we can break (notify) the sleep on stopping the watcher or when we are destroying the NSFW object.
@julianmesa-gitkraken julianmesa-gitkraken force-pushed the fix-segfault-on-exit branch 2 times, most recently from fc8847b to c57ac10 Compare December 15, 2021 14:39
@ianhattendorf ianhattendorf merged commit dd18a13 into Axosoft:master Dec 17, 2021
@ianhattendorf
Copy link
Contributor

@julianmesa-gitkraken the merge commit for this PR failed CI twice in a row, then passed twice in a row. We should investigate this further and see if there might be some flakiness in the tests.

https://github.com/Axosoft/nsfw/actions/runs/1590191960/attempts/1 (you can view other attempts by changing the URL or going to the latest attempt and then clicking View previous attempt).

@julianmesa-gitkraken
Copy link
Contributor Author

@julianmesa-gitkraken the merge commit for this PR failed CI twice in a row, then passed twice in a row. We should investigate this further and see if there might be some flakiness in the tests.

https://github.com/Axosoft/nsfw/actions/runs/1590191960/attempts/1 (you can view other attempts by changing the URL or going to the latest attempt and then clicking View previous attempt).

Seems an error conection

Error: Timeout of 120000ms exceeded.

When trying to do a git clone on an external repo: git clone https://github.com/implausible/nsfw-stress-test
Sometimes it occurs locally as well, but rarely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants